Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation cards can be interacted with the mouse but not with the keyboard #6306

Open
acelaya opened this issue Apr 2, 2024 · 0 comments
Open

Comments

@acelaya
Copy link
Contributor

acelaya commented Apr 2, 2024

One challenge to achieve this is the fact that annotation cards are not focusable at the moment, so we don't have a way to announce this shortcut, but we could probably change this, or at least make them work as long as any inner element is focused.

A similar pattern can be observed at sites like Twitter. In there, every tweet is part of the focus sequence, and they have aria-labelledby pointing to the tweet's text, author and a few other things, role="article" and tabindex="0".

Some time ago, we tried to make annotation cards focusable, but we had to end up reverting it as it caused other problems (more context can be found on our internal slack https://hypothes-is.slack.com/archives/C4K6M7P5E/p1687440646316049).

We should have this in mind if we attempt to solve this again.

Related issue: hypothesis/product-backlog#1425
Some comments include alternative approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant