services.icon is documented, but not working

[tadast]

Docs suggest a custom SVG can be used in the sidebar, but it doesn't appear to be working and I can't seem to find any code that is using this option.

Perhaps it needs to be removed from the docs if the option is not supported?

[robertknight]

The short answer is that this setting still exists but is not effective any more, and we should indeed remove it from the documentation.

This setting is still used in the code, but you'd need to use something like VS Code which understands TypeScript projects to find all usages of the icon field.

To go into more detail, the option was originally added for publishers like eLife who have a white-labeled version of Hypothesis on their site. We subsequently added the concept of "organizations" to Hypothesis which can have their own logo, and that takes priority over the services.icon field. We later made it so that all groups are assigned to an organization, using a default one with a Hypothesis logo if they haven't been assigned to a more specific one. I believe this means, although it needs to be confirmed, that the service.icon value is never used.