Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the use of arrows in menus/popovers #5941

Open
acelaya opened this issue Nov 9, 2023 · 2 comments
Open

Revisit the use of arrows in menus/popovers #5941

acelaya opened this issue Nov 9, 2023 · 2 comments
Assignees

Comments

@acelaya
Copy link
Contributor

acelaya commented Nov 9, 2023

We have been traditionally adding a triangle in popovers and menus, pointing to the element that opened them.

Without rounded corners these were frequently aligned to the very end of one of the element's sides.

With rounded corners this needs to be adjusted, causing some side effects and looking odd in some cases, because it either no longer points to the right place, or it requires the menu/popover to be relocated, causing scrolls to appear.

@acelaya acelaya self-assigned this Nov 9, 2023
@robertknight
Copy link
Member

To clarify the issue here, since we recently rounded many UI elements, including menus, the up-pointing arrow situated near the rounded corner on the right now looks a bit out of place, as you have a rounded curve that transitions into the side of a straight triangle:

Rounded menu with up arrow

@acelaya
Copy link
Contributor Author

acelaya commented Nov 10, 2023

#5942 removed arrows in menus, but we still need to decide what to do with popovers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants