Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the pages that're shown when a site is blocked #118

Open
seanh opened this issue Jan 14, 2021 · 0 comments
Open

Improve the pages that're shown when a site is blocked #118

seanh opened this issue Jan 14, 2021 · 0 comments
Labels

Comments

@seanh
Copy link
Contributor

seanh commented Jan 14, 2021

Depends on:

The pages that Via shows when sites are blocked aren't very good, either in visual design or in wording. Re-design and re-write them to be better.

The block pages are implemented in Checkmate

The code for these block pages can be found in Checkmate:

See below for screenshots and example links for the different block pages.

Checkmate's block pages are used by Via, Via 3 and Via HTML

All three Via's redirect to these Checkmate-hosted block pages when a page is blocked, so any changes made to the block pages in Checkmate apply to all three Via's. In particular, changes apply to both public Via and LMS's Via.

The design should be consistent with other pages in Via 3

The visual design should match the design of existing error pages in Via 3 so that the combined Via / Via 3 / Via HTML UI can be consistent. Via 3's existing error pages also match the design used in the LMS app, so that the combined LMS / Via experience is consistent.

The code for Via 3's error pages is here:

Here's what a Via 3 error page looks like:

Screenshot from 2021-01-21 13-36-29

The design should work in the LMS context

We can't tell LMS users to install the browser extension. You can't log in to your LMS account in the browser extension, so this instruction doesn't make sense in the LMS context.

The Via 3 error page above features a white box floating on a grey background. The grey background is needed in the LMS context to distinguish our iframe from the surrounding LMS. If the background is white then the user can't see where Canvas ends and Hypothesis begins and can't tell whether the error message is coming from Hypothesis or Canvas.

The horizontal and vertical centering of the dialog is also important for this reason.

Here's what the Via 3 error dialog looks like in the LMS context:

Screenshot from 2021-01-21 13-42-48

Current pages

Current page when the domain is not on our allow-list

not-allowed

Current page when the domain is marked as malicious on our blocklist

malicious

Current page when a publisher has requested that we block their site

publisher-blocked

Current page when a domain is an our blocklist for any other reason

E.g. when we block sites like YouTube.

other

@seanh seanh added this to the Reduce friction of annotating not-yet-allowed sites with public Via milestone Jan 14, 2021
@seanh seanh modified the milestones: Ideas: Reduce friction of annotating not-yet-allowed sites with public Via, 2. Add an allow-list to public Via Jan 14, 2021
@seanh seanh added the frontend label Jan 21, 2021
@seanh seanh added this to To do in Secure Via Feb 15, 2021
@seanh seanh removed this from Backlog in Secure Via Feb 15, 2021
@seanh seanh removed this from the 2. Add an allow-list to public Via milestone Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant