Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Websocket over TLS in iroha_client doesn't work with rustls (default configuration) #4120

Closed
DCNick3 opened this issue Dec 7, 2023 · 2 comments
Closed

[BUG] Websocket over TLS in iroha_client doesn't work with rustls (default configuration) #4120

DCNick3 opened this issue Dec 7, 2023 · 2 comments
Assignees
@DCNick3 @AlexStroke
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@DCNick3
Copy link
Contributor

DCNick3 commented Dec 7, 2023 •
edited

Reported here: #4099 (comment) and in dev chat (https://t.me/c/1705484471/15317)

Seems to be a bug with cargo feature usage on tokio-tungstenite side. Investigating it...
@DCNick3 DCNick3 added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Dec 7, 2023
@DCNick3 DCNick3 self-assigned this Dec 7, 2023
@DCNick3
Copy link
Contributor Author

DCNick3 commented Dec 7, 2023 •
edited

It appears to not be a bug, but a gotcha with using a re-exported sync version of tungstenite: snapview/tokio-tungstenite#313

TL;DR: we are using tokio-tungstenite's re-exported version of tungstenite. tokio-tungstenite's rustls-tls-native-roots feature has the full effect only on tokio-tungstenite, leaving tungstenite's TLS in half-working state.

We should not use the re-exported version of tungstenite.

The async version should not be affected

DCNick3 added a commit that referenced this issue Dec 7, 2023
@DCNick3
[fix] #4120: Do not use the tungstenite re-exported from `tokio_tun…
dd511cf 
…gstenite`

Re-exported does not have the TLS fully functional if we only enable it on `tokio-tungstenite`, so a direct dependency is required
@DCNick3 DCNick3 mentioned this issue Dec 7, 2023
Merged
1 task
DCNick3 added a commit that referenced this issue Dec 7, 2023
@DCNick3
[fix] #4120: Do not use the tungstenite re-exported from `tokio_tun…
46117d5 
…gstenite`

Re-exported does not have the TLS fully functional if we only enable it on `tokio-tungstenite`, so a direct dependency is required

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
@DCNick3 DCNick3 changed the title [BUG] Websocket over TLS in iroha_client doesn't work with rustls (default configuration [BUG] Websocket over TLS in iroha_client doesn't work with rustls (default configuration) Dec 7, 2023
DCNick3 added a commit that referenced this issue Dec 8, 2023
@DCNick3
[fix] #4120: Do not use the tungstenite re-exported from `tokio_tun…
2c3a4ce 
…gstenite`

Re-exported does not have the TLS fully functional if we only enable it on `tokio-tungstenite`, so a direct dependency is required

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
DCNick3 added a commit to DCNick3/iroha that referenced this issue Dec 8, 2023
@DCNick3
[BACKPORT] hyperledger#4120: Do not use the tungstenite re-exported…
b9b1537 
… from `tokio_tungstenite`

Re-exported does not have the TLS fully functional if we only enable it on `tokio-tungstenite`, so a direct dependency is required

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
@DCNick3 DCNick3 mentioned this issue Dec 8, 2023
Merged
1 task
mversic pushed a commit that referenced this issue Dec 8, 2023
@DCNick3
[BACKPORT] #4120: Do not use the tungstenite re-exported from `toki…
20dcfb8 
…o_tungstenite` (#4128)

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
mversic added a commit to mversic/iroha that referenced this issue Dec 8, 2023
@mversic
Revert "[fix] hyperledger#4120: Do not use the tungstenite re-expor…
7be2df8 
…ted from `tokio_tungstenite`"

This reverts commit 2c3a4ce.
@AlexStroke AlexStroke self-assigned this Dec 11, 2023
@AlexStroke
Copy link
Contributor

Still got this error.
telegram-cloud-photo-size-2-5456251214057558323-y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DCNick3 DCNick3

@AlexStroke AlexStroke

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DCNick3 @AlexStroke