This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Ensure supported Node versions for all dependencies #562
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaw 4.x was named as a dependency of fabric-client and is also a transient dependency of recent versions of jsdoc. This version of klaw requires Node 14 and broke client applications using engine-strict. Some other transient dev dependencies also caused issues with engine-strict enable so the versions of dependencies that reference them are locked down more tightly. Add a .npmrc with engine-strict=true so Node version incompatibilities break the build. Signed-off-by: Mark S. Lewis <mark_lewis@uk.ibm.com>
bestbeforetoday
force-pushed
the
engine-strict
branch
from
5364f33 to
a3eb3c8
Compare
andrew-coleman
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
klaw 4.x was named as a dependency of fabric-client and is also a transient dependency of recent versions of jsdoc. This version of klaw requires Node 14 and broke client applications using engine-strict.
Some other transient dev dependencies also caused issues with engine-strict enable so the versions of dependencies that reference them are locked down more tightly.
Add a .npmrc with engine-strict=true so Node version incompatibilities break the build.
Signed-off-by: Mark S. Lewis mark_lewis@uk.ibm.com