Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally load jemalloc #7047

Open
amsmota opened this issue May 3, 2024 · 3 comments
Open

Optionally load jemalloc #7047

amsmota opened this issue May 3, 2024 · 3 comments

Comments

@amsmota
Copy link

amsmota commented May 3, 2024

Description

As an Developer/Devops/Tester, I want to enable/disable the use of jemalloc when starting Besu so that I can easily test performance with/without jemalloc and be able to start without jemalloc if there is a memory issue on startup.

Acceptance Criteria

  • Besu will load jemalloc optionally based on a env var

Versions

  • All Linux based versions

Implementation

I was able to implement and test this feature by reusing the BESU_USING_JEMALLOC env var, with changes in the initial besu start script and a few lines in ConfigurationOverviewBuilder.

If set, BESU_USING_JEMALLOC=true will load jemalloc, if set to anything else it won't. If BESU_USING_JEMALLOC is not set at all it'll load it too (that is the existing behavior).

If enough people think this is useful I am ready to create a PR.

@macfarla
Copy link
Contributor

@amsmota I think it would be great if you could do a PR for this

@amsmota
Copy link
Author

amsmota commented May 14, 2024

I will. Thanks... 👍

@amsmota I think it would be great if you could do a PR for this

amsmota added a commit to Citi/besu that referenced this issue May 14, 2024
Signed-off-by: Antonio Mota <antonio.mota@citi.com>
amsmota added a commit to Citi/besu that referenced this issue May 14, 2024
Signed-off-by: Antonio Mota <antonio.mota@citi.com>
@amsmota
Copy link
Author

amsmota commented May 15, 2024

Hi @macfarla, I opened the PR already, see above.

Thanks. 👍

amsmota added a commit to Citi/besu that referenced this issue May 18, 2024
… after review

Signed-off-by: Antonio Mota <antonio.mota@citi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants