From cb6592f793e0c351db0d382c055f6d93ee3b7d5c Mon Sep 17 00:00:00 2001 From: tottoto Date: Thu, 31 Mar 2022 18:43:21 +0900 Subject: [PATCH] chore: Fix clippy lints --- tonic-build/src/prost.rs | 2 +- tonic/src/service/interceptor.rs | 2 +- tonic/src/transport/server/conn.rs | 5 +---- tonic/src/transport/server/mod.rs | 1 - 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/tonic-build/src/prost.rs b/tonic-build/src/prost.rs index d5a1b2789..2c74ed5cf 100644 --- a/tonic-build/src/prost.rs +++ b/tonic-build/src/prost.rs @@ -388,7 +388,7 @@ impl Builder { PathBuf::from(std::env::var("OUT_DIR").unwrap()) }; - config.out_dir(out_dir.clone()); + config.out_dir(out_dir); if let Some(path) = self.file_descriptor_set_path.as_ref() { config.file_descriptor_set_path(path); } diff --git a/tonic/src/service/interceptor.rs b/tonic/src/service/interceptor.rs index c6731cadc..cb8d46bdb 100644 --- a/tonic/src/service/interceptor.rs +++ b/tonic/src/service/interceptor.rs @@ -169,7 +169,7 @@ where // HTTP method of the HTTP request, so we extract them here and then add them back in below. let uri = req.uri().clone(); let method = req.method().clone(); - let version = req.version().clone(); + let version = req.version(); let req = crate::Request::from_http(req); let (metadata, extensions, msg) = req.into_parts(); diff --git a/tonic/src/transport/server/conn.rs b/tonic/src/transport/server/conn.rs index 53bd47c31..40a303d93 100644 --- a/tonic/src/transport/server/conn.rs +++ b/tonic/src/transport/server/conn.rs @@ -116,10 +116,7 @@ where let inner = inner.connect_info(); let certs = if let Some(certs) = session.peer_certificates() { - let certs = certs - .into_iter() - .map(|c| Certificate::from_pem(c)) - .collect(); + let certs = certs.iter().map(Certificate::from_pem).collect(); Some(Arc::new(certs)) } else { None diff --git a/tonic/src/transport/server/mod.rs b/tonic/src/transport/server/mod.rs index 8201dbe12..aa2db0d42 100644 --- a/tonic/src/transport/server/mod.rs +++ b/tonic/src/transport/server/mod.rs @@ -151,7 +151,6 @@ impl Server { /// Configure TLS for this server. #[cfg(feature = "tls")] #[cfg_attr(docsrs, doc(cfg(feature = "tls")))] - #[must_use] pub fn tls_config(self, tls_config: ServerTlsConfig) -> Result { Ok(Server { tls: Some(tls_config.tls_acceptor().map_err(Error::from_source)?),