Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Prepare 0.7.1 release #962

Merged
merged 1 commit into from Apr 4, 2022
Merged

chore: Prepare 0.7.1 release #962

merged 1 commit into from Apr 4, 2022

Conversation

LucioFranco
Copy link
Member

No description provided.

davidpdrsn
davidpdrsn reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I this a breaking change? Does it change what default_features = false pulls in?

@LucioFranco
Copy link
Member Author

@davidpdrsn no this only adds a new feature that is a subset of the transport feature which is included automatically. So this only adds a feature with one less dep than transport. I don't think its a breaking change.

@davidpdrsn
Copy link
Member

Yeah I think you're right.

If someone did default_features = false, features = ["transport"] then this doesn't change, since like you say channel is a subset of transport.

🚢

@LucioFranco LucioFranco merged commit 88695c0 into master Apr 4, 2022
@LucioFranco LucioFranco deleted the lucio/prepare-7.1 branch April 4, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LucioFranco @davidpdrsn