Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update tokio-util to 0.7 #949

Merged
merged 1 commit into from Mar 30, 2022

Conversation

adamchalmers
Copy link
Contributor

Motivation

The tokio ecosystem has been moving to tokio-util 0.7 -- e.g. h2 has just upgraded to it. In my project, tonic is the only holdout still on 0.6, so if we upgrade, my project will have fewer crates to compile.

Solution

Bump tokio-util from 0.6 to 0.7

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamchalmers
Copy link
Contributor Author

adamchalmers commented Mar 29, 2022

Actually, let's hold off on merging this until a new release of h2 is out, because right now we're still using the h2 version that uses tokio-utils 0.6.9 -- so this PR, as is, doesn't remove 0.6.9 from the tree.

@adamchalmers adamchalmers marked this pull request as draft March 29, 2022 21:44
@adamchalmers adamchalmers marked this pull request as ready for review March 29, 2022 21:52
@adamchalmers
Copy link
Contributor Author

adamchalmers commented Mar 29, 2022

Actually, once H2 cuts their new release, it will be 0.3.13, which is still compatible with tonic's bound on h2 = {version = "0.3", optional = true}.

So, this PR causes tonic to use both h2 0.6 and 0.7, but only for the short time until h2 cuts a new patch release. Then tonic will only use h2 0.7. I spoke to the Hyper folks in Discord and they said they can cut a release tomorrow. So I feel OK merging this.

@LucioFranco
Copy link
Member

Yeah, I think thats fine things will eventually roll up to the newer version.

@LucioFranco LucioFranco changed the title Update tokio-util to 0.7 chore: Update tokio-util to 0.7 Mar 30, 2022
@LucioFranco LucioFranco merged commit 350ccf9 into hyperium:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants