Inconsistent Server Builder api - timeout func returns &mut Self instead of Self

[jdahlq]

Feature Request

Crates

tonic

Motivation

Similar functions in the Builder return Self rather than &mut Self enabling move semantics, but timeout doesn't, leading to quirky behavior.

// This compiles because `add_service` takes a `&mut Self` and clones it.
let router = Server::builder()
  .accept_http1(true)
  .timeout(Duration::from_secs(10))
  .add_service(my_svc);

// This does NOT compile because `accept_http1` takes a `Self` but cannot move or copy it.
let router = Server::builder()
  .timeout(Duration::from_secs(10))
  .accept_http1(true)
  .add_service(my_svc);

Issue #115 changed most of these functions to return Self, but timeout was (re-)introduced in PR #199 and (presumably unintentionally) uses the old behavior of returning &mut Self.

Proposal

Make timeout consistent with other funcs like accept_http1, concurrency_limit_per_connection, etc.

[LucioFranco]

Nice catch! Yeah, we should get this fixed :)