Remove tonic-web custom cors implementation and replace it with tower-http CorsLayer
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
issues/1122
branch
3 times, most recently
from
7ab10a3
to
5cefddf
Compare
|
I tested this branch on a personal project, connecting with connect-web client with grpc-web transport, and it works fine. |
slinkydeveloper
commented
Oct 25, 2022
slinkydeveloper
force-pushed
the
issues/1122
branch
from
ceed9c1
to
eb7d75a
Compare
LucioFranco
reviewed
Oct 28, 2022
LucioFranco
reviewed
Oct 28, 2022
Closed
slinkydeveloper
force-pushed
the
issues/1122
branch
from
eb7d75a
to
f54c43e
Compare
slinkydeveloper
changed the title
CorsLayerCorsLayer
…-http `CorsLayer`. Fix hyperium#1122 Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
issues/1122
branch
from
f54c43e
to
216f410
Compare
|
For me this is ready now, it would be nice if someone else can test it though :) |
LucioFranco
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1122, see the issue for more details.
This PR depends on #1119