Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add cleanup-markdown feature flag #1086

Merged
merged 5 commits into from Sep 28, 2022
Merged

feat(build): add cleanup-markdown feature flag #1086

merged 5 commits into from Sep 28, 2022

Conversation

nylonicious
Copy link
Contributor

Closes #1073

I also documented the feature flags.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco
Copy link
Member

Looks like we just have a CI failure that needs to be resolved before we can merge

@nylonicious
Copy link
Contributor Author

nylonicious commented Sep 26, 2022

All tests run fine on my local machine, so I'm not sure what's the issue. I've rebased but CI need approval.

@LucioFranco
Copy link
Member

Ah @nylonicious since this changes the output of the generated code for tonic-types you will need to run cargo test --all then commit the extra code that was updated. That is why CI is failing.

@nylonicious
Copy link
Contributor Author

I see, my bad. It now passes cargo test --all --all-features locally.

@LucioFranco LucioFranco merged commit c1b08df into hyperium:master Sep 28, 2022
@nylonicious nylonicious deleted the cleanup-markdown-flag branch September 30, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cleanup-markdown prost_build feature
2 participants