Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Result<T> type alias for std::result::Result<T, tonic::Status> #1085

Merged
merged 4 commits into from Sep 26, 2022

Conversation

stphnsmpsn
Copy link
Contributor

@stphnsmpsn stphnsmpsn commented Sep 23, 2022

Motivation

#1084

Solution

Added a simple alias in lib.rs: pub type Result<T, E = Status> = std::result::Result<T, E>;

tonic/src/lib.rs Outdated Show resolved Hide resolved
stphnsmpsn and others added 2 commits September 23, 2022 19:52
Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@LucioFranco
Copy link
Member

One cI failure though that is probably cuz of formatting https://github.com/hyperium/tonic/actions/runs/3116115959/jobs/5054123932

@stphnsmpsn
Copy link
Contributor Author

@LucioFranco , it was a formatting issue my bad. Passes cargo fmt now.

@LucioFranco LucioFranco merged commit 56ff45d into hyperium:master Sep 26, 2022
@punkeel punkeel mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants