Expose Extensions::into_http and Status::from_error #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could we publish a new version with this change so that I can publish my async_interceptor crate? Sorry to bug you about this, just trying to close the loop here :) |
|
(@jdahlq: I'm waiting for your crate to be published :D) |
|
@jdahlq I can get a release out next week there are a couple more PRs I wanna get merged for that, if thats okay. |
|
@LucioFranco Sounds good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose Extensions::into_http and Status::from_error as public.
Motivation
See #910. These functions must be public in order to implement async_interceptor in its own external crate.