Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Service and HttpService without features #3590

Open
tottoto opened this issue Mar 1, 2024 · 2 comments
Open

Expose Service and HttpService without features #3590

tottoto opened this issue Mar 1, 2024 · 2 comments
Labels
C-feature Category: feature. This is adding a new feature.

Comments

@tottoto
Copy link
Contributor

tottoto commented Mar 1, 2024 •
edited

I would suppose that hyper-util would be good to allow users to enable http1 or/and http2 feature separately when using server-auto feature (although it is a breaking change). As hyper-util uses Service and HttpService to implement server-auto feature, these traits are required without http{1,2} features. Since these traits do not actually require optional dependencies, the drawback to expose them seems small comparing the benefit.
@tottoto tottoto added the C-feature Category: feature. This is adding a new feature. label Mar 1, 2024
@tottoto tottoto mentioned this issue Mar 2, 2024
Merged
@tottoto
Copy link
Contributor Author

tottoto commented Mar 2, 2024

This allows hyper-util to enable its service util without http1 and http2 features as well.

refs: hyperium/hyper-util#79

@tottoto
Copy link
Contributor Author

tottoto commented Mar 2, 2024

hyperium/hyper-util#105 is a motivation for this proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature Category: feature. This is adding a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tottoto