Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky benchmark for http2 with adaptive window #3572

Open
dswij opened this issue Feb 16, 2024 · 1 comment
Open

Flaky benchmark for http2 with adaptive window #3572

dswij opened this issue Feb 16, 2024 · 1 comment
Labels
C-bug Category: bug. Something is wrong. This is bad!

Comments

@dswij
Copy link
Member

dswij commented Feb 16, 2024

The benchmark for the http2 adaptive window is inconsistent across runs. This will cause CI to be marked as a failure occasionally whenever there is a drop in benchmark results.

See for example https://github.com/hyperium/hyper/actions/runs/7786695842/job/21232101297.

@dswij dswij added the C-bug Category: bug. Something is wrong. This is bad! label Feb 16, 2024
@seanmonstar
Copy link
Member

Yea, I think a problem with that benchmark is that it would most helpful when we can "control" the bandwidth. Currently, since it's a connection of localhost, it can blast all the bytes at full speed (fuller than real world), and then it's just based on the scheduler and other guests on the CI runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug. Something is wrong. This is bad!
Projects
None yet
Development

No branches or pull requests

2 participants