Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limited clippy to CI #2977

Open
seanmonstar opened this issue Sep 7, 2022 · 3 comments · May be fixed by #3153
Open

Add limited clippy to CI #2977

seanmonstar opened this issue Sep 7, 2022 · 3 comments · May be fixed by #3153
Labels
A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

Add a new job to CI, clippy, but that is extremely limited in what lints it checks for. Clippy's defaults are usually too annoying, but there a few specific things that I would like to catch in an automated fashion:

Add the job as a needs dependency of the ci-pass top-level job.
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. labels Sep 7, 2022
@mastrzyz
Copy link

mastrzyz commented Sep 13, 2022 •
edited

Taking a look on this!

@mastrzyz mastrzyz mentioned this issue Sep 13, 2022
Open
@dswij
Copy link
Member

dswij commented Sep 21, 2022

Clippy's defaults are usually too annoying

@seanmonstar that's unfortunate to hear. Is there a specific lint that comes to mind, or is it the false positives in general?

@tomkarw
Copy link
Contributor

tomkarw commented Sep 21, 2022

I was surprised to see hyper not utilizing clippy to it's fullest. I usually run projects with pedantic enabled, and it has been nothing but valuable to me.

I already saw hyper-utils having some clippy warnings, maybe it would be easier there, to keep it strict from the get-go?

@palango palango linked a pull request Feb 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tests Area: tests. C-refactor Category: refactor. This would improve the clarity of internal code. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clippy to CI palango/hyper
4 participants
@seanmonstar @tomkarw @mastrzyz @dswij