Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http1): fix h1_header_read_timeout_running #2891

Merged
merged 1 commit into from Jun 13, 2022
Merged

fix(http1): fix h1_header_read_timeout_running #2891

merged 1 commit into from Jun 13, 2022

Conversation

silence-coding
Copy link
Contributor

Fix: #2888

@silence-coding
Copy link
Contributor Author

@seanmonstar

@seanmonstar
Copy link
Member

@paolobarbolini does it seem like this is all that's needed? Or are there any other places that need to set it too?

@paolobarbolini
Copy link
Contributor

@paolobarbolini does it seem like this is all that's needed? Or are there any other places that need to set it too?

Yeah this is the only place.

@seanmonstar seanmonstar merged commit 5fa113e into hyperium:master Jun 13, 2022
seanmonstar pushed a commit that referenced this pull request Jul 7, 2022
@silence-coding @seanmonstar
fix(http1): fix http1_header_read_timeout to use same future (#2891)
c5a14e7 
Co-authored-by: silence <xxx@email.com>
(cherry picked from commit 5fa113e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

h1_header_read_timeout_running is never set to true
3 participants
@silence-coding @seanmonstar @paolobarbolini