Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how hyper is using UpgradedSendStream safely #2829

Open
erickt opened this issue May 10, 2022 · 0 comments
Open

Document how hyper is using UpgradedSendStream safely #2829

erickt opened this issue May 10, 2022 · 0 comments
Labels
C-feature Category: feature. This is adding a new feature.

Comments

@erickt
Copy link
Contributor

erickt commented May 10, 2022

Is your feature request related to a problem? Please describe.

On Fuchsia, we are updating our vendored version of Hyper from 0.13 to 0.14 in https://fuchsia-review.googlesource.com/c/fuchsia/+/611683/. As part of this we are reviewing the hyper change. One portion of the codebase we are struggling with is src/proto/h2. In #2523, @nox introduced the unsafe UpgradedSendStream and Neutered, and it's not straightforward what it does, and how we know hyper is using it correctly.

Describe the solution you'd like

There's a nice discussion though in #2523 that gives some context. It would be helpful if a version of this discussion was added to the code. That would make it easier to review vendored code.

@erickt erickt added the C-feature Category: feature. This is adding a new feature. label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature. This is adding a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant