feat(error): add Error::message
#2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
nox
approved these changes
Feb 4, 2022
seanmonstar
approved these changes
Feb 5, 2022
|
@seanmonstar any chance you wanna cut a release with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate solution to #2732 that doesn't change
hyper::Error'sDisplayimpl (like #2542 does).It adds
Error::messagewhich returns the message that is unique to the error, without the message from the source. That way users can create a newtype aroundhyper::Errorand use this in theDisplayimpl to work around #2732.Fixes #2732