fix(server): use case-insensitive comparison for Expect: 100-continue #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanMurray
changed the title
src/proto/h1/role.rs
Outdated
| // According to https://datatracker.ietf.org/doc/html/rfc2616#section-14.20 | ||
| // Comparison of expectation values is case-insensitive for unquoted tokens | ||
| // (including the 100-continue token) | ||
| expect_continue = value.to_str().map(|s| s.eq_ignore_ascii_case("100-continue")).unwrap_or(false); |
There was a problem hiding this comment.
eq_ignore_ascii_case should also available with .as_bytes()
See: https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.eq_ignore_ascii_case
There was a problem hiding this comment.
Ah, that's great! Using that instead now.
added 2 commits
November 30, 2021 14:59
According to rfc2616#section-14.20 the header value is case- insensitive. Certain clients (including Java's std lib https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/master/src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java#L408) send the expectation as `100-Continue` and this should be handled by the server. Closes: #2708
seanmonstar
approved these changes
Nov 30, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to rfc2616#section-14.20 the header value is case-
insensitive. Certain clients (including Java's std lib
https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/master/src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java#L408)
send the expectation as
100-Continueand this should be handledby the server.
(This is an attempt to address #2708)