Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headers): apply header title case for consecutive dashes #2613

Merged
merged 1 commit into from Aug 6, 2021

Conversation

blyxxyz
Copy link
Contributor

@blyxxyz blyxxyz commented Aug 4, 2021

Fix the header title-casing to work with consecutive dashes. Previously with two dashes in a row the first dash would uppercase the second dash which would then not count, so weird--header would be cased as Weird--header instead of Weird--Header.

Fix the header title-casing to work with consecutive
dashes. Previously with two dashes in a row the first dash would
uppercase the second dash which would then not count, so
`weird--header` would be cased as `Weird--header` instead of
`Weird--Header`.
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I like that the code as a whole is simpler, thanks!

@seanmonstar seanmonstar merged commit 684f2fa into hyperium:master Aug 6, 2021
@blyxxyz blyxxyz deleted the fix-header-title-case branch August 6, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants