Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose http09 and http1 options on low-level client connection builders. #2611

Merged
merged 2 commits into from Aug 4, 2021

Conversation

aturon
Copy link
Contributor

@aturon aturon commented Aug 3, 2021

These options are currently available on the high-level builder only.

Along the way, rename the setters to follow the public API conventions and add docs.

Closes #2461

client connection builders.

These options are currently available on the high-level builder only.

Along the way, rename the setters to follow the public API conventions
and add docs.

Closes hyperium#2461
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Looks great to me.

@aturon
Copy link
Contributor Author

aturon commented Aug 4, 2021

It looks like some tests are failing for (I think?) unrelated reasons.

The trailing semicolon issue on nightly seems to stem from rust-lang/rust#87385

I don't know enough about the hyper.h check to comment on that.

@seanmonstar
Copy link
Member

Ah, ok, got #2612 in to fix those errors. Wanna rebase?

@aturon
Copy link
Contributor Author

aturon commented Aug 4, 2021

Passing now, ty!

@seanmonstar seanmonstar merged commit 73bff4e into hyperium:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http1 options are exposed through client::Builder but not lower-level client::conn::Builder interface
2 participants