refactor(lib): Switch from pin-project to pin-project-lite (again) #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
changed the title
seanmonstar
reviewed
Jun 4, 2021
|
Note the practical affects of this PR:
🎉 |
|
I'm actually a bit surprised about the dependency diff. pin-project should "only" pull in pin-project-internal > syn > quote > proc-macro2 > unicode-xid AFAICT. |
|
Hm, I think you're right. I just based that number off making a new crate, adding hyper as a dependency (to not get any dev-dependencies), and then recording how it says |
|
Ah, paying more attention, it's because the |
|
Will there be a patch release with this soon? |
|
Yep, just released v0.14.9. |
BenxiangGe
pushed a commit
to BenxiangGe/hyper
that referenced
this pull request
Jul 26, 2021
…2566) Note the practical affects of this change: - Dependency count with --features full dropped from 65 to 55. - Time to compile after a clean dropped from 48s to 35s (on a pretty underpowered VM). Closes hyperium#2388
edmorley
added a commit
to edmorley/bollard
that referenced
this pull request
Feb 28, 2022
This is another small step towards reducing the size of bollard's dependency tree :-) `tokio` and `hyper` have both switched from `pin-project` crate to the lighter-weight `pin-project-lite`: tokio-rs/tokio#1778 hyperium/hyper#2566 This does the same for bollard. For the differences between the two crates, see: https://docs.rs/pin-project-lite/0.2.8/pin_project_lite/#pin-project-vs-pin-project-lite Note: The full advantage of this won't be seen until a new `hyperlocal` release exists that contains: softprops/hyperlocal#54 ...and bollard updates to that release, so that `pin-project` can be fully dropped from the dependency tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try, turned out to require a bunch more changes in
src/client/conn.rsandsrc/server/conn.rsdue to theProtoClientandProtoServerenums which previously hadcfg-conditional variants (which aren't supported by pin-project-lite). Now the variants that previously were disabled bycfg(not(feature = "http1"))andcfg(not(feature = "http2"))are instead made to be uninhabited.The code would be a decent amount simpler if the non-exhaustive variants could be omitted in
matches (rust-lang/rust#51085).