Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new methods for parsing with uninitialized headers from httparse #2545

Merged
merged 7 commits into from Aug 19, 2021

Conversation

Soveu
Copy link
Contributor

@Soveu Soveu commented May 11, 2021

This patch fixes #2532
It uses methods implemented in this PR in this PR, so CI might fail before it gets merged

@@ -1,9 +1,7 @@
// `mem::uninitialized` replaced with `mem::MaybeUninit`,
// can't upgrade yet
#![allow(deprecated)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#![allow(deprecated)]

@seanmonstar
Copy link
Member

Alright, I've released httparse v1.5.0, so we can use it in this branch, and then merge 'er in!

@Soveu
Copy link
Contributor Author

Soveu commented Aug 19, 2021

Some commit messages are invalid 😔

@Soveu
Copy link
Contributor Author

Soveu commented Aug 19, 2021

How am I supposed to change commit messages now?

@seanmonstar
Copy link
Member

Don't worry about the commit messages, I can adjust it when squashing/merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace usage of mem::uninitialized with MaybeUninit
2 participants