Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server debug panic on Expect: 100-continue without Content-Length #1843

Closed
mdonoughe opened this issue Jul 5, 2019 · 0 comments · Fixed by #1983
Closed

server debug panic on Expect: 100-continue without Content-Length #1843

mdonoughe opened this issue Jul 5, 2019 · 0 comments · Fixed by #1983

Comments

@mdonoughe
Copy link

This is related to #1842 but seems distinct enough to warrant its own issue.

When doing Icecast streaming, the client typically sends an authorization header and an Expect: 100-continue to wait for authorization before trying to upload a stream. However, because of #1842 the hyper server decides the client is not actually going to send any data, and if the server is compiled in debug mode, this causes a panic expect-continue needs a body. When built in release mode the server ignores the Expect: 100-continue and handles the message as if it has no body.

You can trigger this using curl: curl -X PUT http://127.0.0.1:5000/ -d test -H 'Expect: 100-continue' -H 'Content-Length:'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant