Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect largest decimal number #618

Open
cloutiertyler opened this issue Jul 30, 2023 · 0 comments
Open

Incorrect largest decimal number #618

cloutiertyler opened this issue Jul 30, 2023 · 0 comments

Comments

@cloutiertyler
Copy link

https://github.com/hyperium/http/blob/78e3d37563b0fe83886abffdcd8569117d45fee9/src/header/value.rs#L421|

The comment here states:

// The largest decimal number in 15 digits:
// It wold be 10.pow(15) - 1, but this is a constant
// version.
if num as u64 > 999_999_999_999_999_999 {

However, 999_999_999_999_999_999 is actually 18 digits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cloutiertyler