Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CROSS_ORIGIN_EMBEDDER_POLICY and CROSS_ORIGIN_OPENER_POLICY constants #460

Open
ssokolow opened this issue Jan 5, 2021 · 3 comments · May be fixed by #562
Open

Add CROSS_ORIGIN_EMBEDDER_POLICY and CROSS_ORIGIN_OPENER_POLICY constants #460

ssokolow opened this issue Jan 5, 2021 · 3 comments · May be fixed by #562

Comments

@ssokolow
Copy link

ssokolow commented Jan 5, 2021

I'm currently building a site using actix-web, which relies on the http crate for strongly-typed header constants, and I noticed that there are a couple of headers which don't yet have constants here, forcing me to resort to manually specifying them as strings.

Specifically:

As these headers need to be set to enable access to browser features like SharedArrayBuffer and un-throttled performance timers, I think it'd make sense to add CROSS_ORIGIN_EMBEDDER_POLICY and CROSS_ORIGIN_OPENER_POLICY constants.
@djc
Copy link

djc commented Jan 5, 2021

Since these are standardized in the HTML living standard, just submit a PR.

@ssokolow
Copy link
Author

ssokolow commented Jan 5, 2021 •
edited

Right now, it's hard to find time for "annoying, but not show-stopping" stuff like this, so I'll have to just put it on my TODO list.

(As in I'll add a // TODO: Pending hyperium/http#460 comment in my code and defer it until my next clean-up sweep.)

@dekellum
Copy link
Contributor

dekellum commented Jan 5, 2021 •
edited

Ooops, sorry, I got header constants and status code constants confused, folks. Please ignore me.

Are these now also in the IANA list? That list is the only one claimed to be completely covered here. See #453 for background (also a good template for a new PR, I hope).

@HKalbasi HKalbasi mentioned this issue Jan 19, 2022
Closed
@daxpedda daxpedda linked a pull request Jul 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement COOP and COEP daxpedda/http
3 participants
@ssokolow @dekellum @djc