Add convenience Uri getters #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parts of the `Uri` that now have specific types meant that several methods were deprecated, such as `Uri::scheme()` for `Uri::scheme_part()`. This means that many use-cases have extra `map`ping code to get the original value. This adds convenience getters to reduce the need to map when the actual type is not needed: - `scheme_str` - `port_u16`
carllerche
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of the
Urithat now have specific types meant that severalmethods were deprecated, such as
Uri::scheme()forUri::scheme_part(). This means that many use-cases have extramapping code to get the original value.This adds convenience getters to reduce the need to map when the actual
type is not needed:
scheme_strport_u16