Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose http::headers::{IterMut, ValuesMut} #278

Merged
merged 1 commit into from Nov 8, 2018

Conversation

per-gron
Copy link
Contributor

@per-gron per-gron commented Nov 8, 2018

It seems like these exports were omitted unintentionally.

The inability to name these types is giving me some grief in my work in tower-grpc where I'm trying to wrap HeaderMap in a wrapper that exposes an API in terms of gRPC metadata.

See tower-rs/tower-grpc#90

It seems like these exports were not omitted intentionally.

The inability to name these types is giving me some grief in my work in tower-grpc where I'm trying to wrap HeaderMap in a wrapper that exposes an API in terms of gRPC metadata.
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems like an oversight, thanks!

@seanmonstar seanmonstar merged commit 22ec10a into hyperium:master Nov 8, 2018
@per-gron per-gron deleted the patch-2 branch November 8, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants