Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the percent character in the userinfo of an authority. #269

Merged
merged 2 commits into from Oct 30, 2018
Merged

Allow the percent character in the userinfo of an authority. #269

merged 2 commits into from Oct 30, 2018

Conversation

arsing
Copy link
Contributor

@arsing arsing commented Oct 29, 2018

The username and password in an authority are percent-encoded.

@arsing
Allow the percent character in the userinfo of an authority.
8d0d405 
The username and password in an authority are percent-encoded.
@seanmonstar
Copy link
Member

Seems fine, mind including a comment next to the code with a link to the relevant RFC/section so Future Us doesn't forget the why?

@arsing
Copy link
Contributor Author

arsing commented Oct 30, 2018 •
edited

Do you have any preference between https://tools.ietf.org/html/rfc3986#section-3.2.1 and https://url.spec.whatwg.org/#set-the-username https://url.spec.whatwg.org/#authority-state ?

@seanmonstar
Copy link
Member

Thanks!

@seanmonstar seanmonstar merged commit 638928f into hyperium:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arsing @seanmonstar