Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty Method considered as valid #262

Merged
merged 1 commit into from Oct 18, 2018
Merged

Fix empty Method considered as valid #262

merged 1 commit into from Oct 18, 2018

Conversation

theredfish
Copy link
Contributor

@theredfish theredfish commented Oct 18, 2018 •
edited

Fix #260 by checking if the length of the src, given to the function Method::from_bytes, is 0. In this case an Error of type InvalidMethod should be returned.

seanmonstar
seanmonstar approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seanmonstar seanmonstar merged commit 4a71708 into hyperium:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theredfish @seanmonstar