Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuildMemberStore#_fetchMany #3420

Merged
merged 5 commits into from Aug 21, 2019
Merged

GuildMemberStore#_fetchMany #3420

merged 5 commits into from Aug 21, 2019

Conversation

Fyko
Copy link
Contributor

@Fyko Fyko commented Aug 2, 2019

Please describe the changes this PR makes and why it should be merged:

This PR fixes issue #3414 where executing <GuildMemberStore>.fetch({ query: 'Fyko' }) would return an empty collection if all members were cached. I tested this and it seems to work flawlessly.

image

Please ignore the other random commits, I reversed them. Travis may fail due to a todo comment.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@monbrey
Copy link
Member

monbrey commented Aug 2, 2019

This is really all it took?

Thanks!

@amishshah amishshah merged commit cc488a8 into discordjs:master Aug 21, 2019
@Fyko Fyko deleted the guildmember-fetchMany branch August 21, 2019 15:56
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
* added DARK_MODE_INVISIBLE

added another constant color that makes embeds appear invisible on DARK mode.

* travis likes trailing commas

* fix: ref issue: discordjs#3414

* fix: removed a random color
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants