Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Collectors): allow collectors to be consumed by for-await-of loops #3269

Merged
merged 1 commit into from Aug 17, 2019

Conversation

bdistin
Copy link
Contributor

@bdistin bdistin commented May 14, 2019

Please describe the changes this PR makes and why it should be merged:
A remake of #3239 with the requested changes, since that pr/branch was closed. This adds the ability to consume collectors with the for-await-of syntax.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@tech6hutch
Copy link

Any updates on this? This would be really useful to me.

@SpaceEEC SpaceEEC merged commit 6d3c55b into discordjs:master Aug 17, 2019
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants