Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: give the unit for collectoroptions time parameter #3219

Merged
merged 1 commit into from Apr 19, 2019
Merged

docs: give the unit for collectoroptions time parameter #3219

merged 1 commit into from Apr 19, 2019

Conversation

PyroTechniac
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
The collector options typedef doesn't give what unit the collector is for, this PR fixes that

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@PyroTechniac PyroTechniac changed the title fix: give the unit for collectoroptions time parameter docs: give the unit for collectoroptions time parameter Apr 18, 2019
@SpaceEEC SpaceEEC merged commit bccbb55 into discordjs:master Apr 19, 2019
@PyroTechniac PyroTechniac deleted the patch-1 branch April 20, 2019 16:32
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants