Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Invite): add deletable getter #3203

Merged
merged 7 commits into from Apr 22, 2019
Merged

Conversation

izexi
Copy link
Contributor

@izexi izexi commented Apr 14, 2019

To be able to delete an Invite you require the MANAGE_CHANNELS permission taking the overwrites of the invite's channel in consideration or the MANAGE_GUILD perm. This doesn't seem very intuitive so a deletable getter would be handy as well as adding consistency with the deletable getters on some of the other structures.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

src/structures/Invite.js Show resolved Hide resolved
src/structures/Invite.js Show resolved Hide resolved
src/structures/Invite.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC merged commit c4b7957 into discordjs:master Apr 22, 2019
@izexi izexi deleted the Invite-deletable branch April 22, 2019 07:40
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
* add Invite#deletable

* fix ci

* reee

* since guild is nullable

* accommodate for external invites

* nit(Invite): use guild instead of channel.guild
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants