src: Fix resume event not being emitted properly #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
previously requested changes
Apr 9, 2019
2 tasks
|
Several bots staying up for already six days. |
Emitting line of code: https://github.com/discordjs/uws/blob/39aa429f94d9668608f69848b3a84db3a3e92914/src/uws.js#L80-L83 Listener attaching is here: https://github.com/discordjs/uws/blob/master/src/uws.js#L128 For reference, found a clue here: discordjs#1528
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…djs#3192) * src: Fix shardResumed event not being emitted * docs: Document Client#error again * src: Fix onError due to incorrect typings * src: handle onError properly for both uws and ws * src: Try to fix silent disconnects when using uWs * fix(WebSocketShard): uws emits plain objects, not errors Emitting line of code: https://github.com/discordjs/uws/blob/39aa429f94d9668608f69848b3a84db3a3e92914/src/uws.js#L80-L83 Listener attaching is here: https://github.com/discordjs/uws/blob/master/src/uws.js#L128 For reference, found a clue here: discordjs#1528
samsamson33
added a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…discordjs#3192)" This reverts commit 0c44008.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Per #3191, the resumed event was not properly being emitted. This PR solves this, and closes #3191.
Status
Semantic versioning classification: