Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send AppRole generate_secret_id Method Metadata Parameter as String #680

Merged
merged 1 commit into from Apr 2, 2021
Merged

Send AppRole generate_secret_id Method Metadata Parameter as String #680

merged 1 commit into from Apr 2, 2021

Conversation

lperdereau
Copy link
Contributor

This PR respond to #656

@lperdereau lperdereau requested a review from a team as a code owner April 2, 2021 20:37
@codecov
Copy link

codecov bot commented Apr 2, 2021 •
edited

Codecov Report

Merging #680 (096eb4d) into develop (d6b04b8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #680   +/-   ##
========================================
  Coverage    83.76%   83.76%           
========================================
  Files           61       61           
  Lines         3215     3216    +1     
========================================
+ Hits          2693     2694    +1     
  Misses         522      522
Impacted Files Coverage Δ
hvac/api/auth_methods/approle.py 100.00% <100.00%> (ø)

@jeffwecan jeffwecan changed the title Fix approle's metadata argument type on secret_id generation Send AppRole generate_secret_id Method Metadata Parameter as String Apr 2, 2021
@jeffwecan jeffwecan added approle AppRole auth method bug labels Apr 2, 2021
jeffwecan
jeffwecan approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lperdereau!

@jeffwecan jeffwecan merged commit 0c8bf51 into hvac:develop Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwecan jeffwecan jeffwecan approved these changes

Assignees
No one assigned
Labels
approle AppRole auth method bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lperdereau @jeffwecan