Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add token_type support to create_kubernetes_role #664

Merged
merged 2 commits into from Feb 5, 2021
Merged

Add token_type support to create_kubernetes_role #664

merged 2 commits into from Feb 5, 2021

Conversation

devlounge
Copy link
Contributor

related to #663

@devlounge devlounge requested a review from a team as a code owner January 29, 2021 10:00
jeffwecan
jeffwecan reviewed Feb 1, 2021
View reviewed changes
hvac/v1/__init__.py Outdated Show resolved Hide resolved
@devlounge @jeffwecan
move token_type before mount_point kwarg
c78e058 
Co-authored-by: Jeffrey Hogan <jhogan@hashicorp.com>
@codecov
Copy link

codecov bot commented Feb 2, 2021 •
edited

Codecov Report

Merging #664 (e88a999) into develop (9f29cad) will decrease coverage by 0.23%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop     #664      +/-   ##
===========================================
- Coverage    84.01%   83.77%   -0.24%     
===========================================
  Files           61       61              
  Lines         3203     3218      +15     
===========================================
+ Hits          2691     2696       +5     
- Misses         512      522      +10
Impacted Files Coverage Δ
hvac/api/secrets_engines/database.py 35.71% <30.76%> (-1.50%) ⬇️
hvac/v1/__init__.py 86.47% <50.00%> (-0.11%) ⬇️

@devlounge
Copy link
Contributor Author

When could this PR get merged and released?

@devlounge
Copy link
Contributor Author

@jeffwecan

@jeffwecan jeffwecan merged commit 4bf882a into hvac:develop Feb 5, 2021
@devlounge devlounge deleted the patch-1 branch February 5, 2021 14:40
@jeffwecan jeffwecan added the kubernetes Kubernetes auth method label Feb 8, 2021
@jeffwecan
Copy link
Member

Will aim to cut a release with this included today!

@jeffwecan jeffwecan changed the title add token_type support to create_kubernetes_role Add token_type support to create_kubernetes_role Feb 8, 2021
@jeffwecan jeffwecan added the enhancement a new feature or addition label Feb 8, 2021
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
@ayav09 ayav09 mentioned this pull request Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwecan jeffwecan jeffwecan left review comments

Assignees
No one assigned
Labels
enhancement a new feature or addition kubernetes Kubernetes auth method
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devlounge @jeffwecan