Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.6 #654

Merged
merged 47 commits into from Dec 17, 2020
Merged

Release v0.10.6 #654

merged 47 commits into from Dec 17, 2020

Conversation

jeffwecan
Copy link
Member

No description provided.

jeffwecan and others added 30 commits July 26, 2020 13:38
Backport Merge pull request #614 from hvac/develop
Updated with correct link
Correct python-requests link
Add rabbitmq vhost_topics parameter
Official documentation (https://www.vaultproject.io/api-docs/secret/transit#generate-data-key) and your own documentation (https://hvac.readthedocs.io/en/stable/usage/secrets_engines/transit.html#generate-data-key) only mentions "plaintext" and "wrapped" as valid value, while "ciphertext" was written here. Moreover, "ciphertext" is not valid and results in the following traceback : 

Traceback (most recent call last):
  File "[...]", line 91, in runcode
    exec(code, self.locals)
  File "<input>", line 4, in <module>
  File "[...]/hvac/api/secrets_engines/transit.py", line 504, in generate_data_key
    json=params,
  File "[...]/hvac/adapters.py", line 107, in post
    return self.request('post', url, **kwargs)
  File "[...]/hvac/adapters.py", line 342, in request
    response = super(JSONAdapter, self).request(*args, **kwargs)
  File "[...]/hvac/adapters.py", line 309, in request
    errors=errors
  File "[...]/hvac/utils.py", line 37, in raise_for_error
    raise exceptions.InvalidRequest(message, errors=errors, method=method, url=url)
hvac.exceptions.InvalidRequest: Invalid path, must be 'plaintext' or 'wrapped', on post https://[...]
Fix PUT method in secrets engine kv_v1 to use PUT instead of POST
Updated to match updated query parameters on Vault API.

https://www.vaultproject.io/api-docs/system/health
remove legacy policy type check
Update health.py to match new Vault API query parameters
Fix oidc login and add working example
Fix transit constants for "generate_data_key"
Add auth_methods module to support AppRole
@jeffwecan jeffwecan requested a review from a team as a code owner December 14, 2020 23:08
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #654 (295955d) into master (17b7343) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   83.41%   84.01%   +0.59%     
==========================================
  Files          59       61       +2     
  Lines        3106     3203      +97     
==========================================
+ Hits         2591     2691     +100     
+ Misses        515      512       -3     
Impacted Files Coverage Δ
hvac/api/auth_methods/jwt.py 92.30% <ø> (ø)
hvac/api/system_backend/health.py 85.71% <ø> (ø)
hvac/constants/transit.py 100.00% <ø> (ø)
hvac/api/auth_methods/__init__.py 80.76% <100.00%> (+0.76%) ⬆️
hvac/api/auth_methods/approle.py 100.00% <100.00%> (ø)
hvac/api/secrets_engines/consul.py 42.30% <100.00%> (+4.37%) ⬆️
hvac/api/secrets_engines/kv_v1.py 100.00% <100.00%> (ø)
hvac/api/secrets_engines/pki.py 100.00% <100.00%> (ø)
hvac/api/secrets_engines/rabbitmq.py 42.30% <100.00%> (ø)
hvac/api/vault_api_category.py 94.44% <100.00%> (ø)
... and 4 more

@jeffwecan jeffwecan merged commit 797bff6 into master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet