Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template "auth method not implemented" error message #651

Merged
merged 1 commit into from Dec 14, 2020

Conversation

briantist
Copy link
Contributor

Fixes #650

Error message for unimplemented auth method doesn't include the auth method name, looks like a simple oversight.

@briantist briantist requested a review from a team as a code owner December 2, 2020 15:25
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #651 (92dbf94) into develop (7a8642e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #651   +/-   ##
========================================
  Coverage    84.01%   84.01%           
========================================
  Files           61       61           
  Lines         3203     3203           
========================================
  Hits          2691     2691           
  Misses         512      512           
Impacted Files Coverage Δ
hvac/api/vault_api_category.py 94.44% <100.00%> (ø)

@briantist briantist changed the title Template auth method not implemented error message Template "auth method not implemented" error message Dec 3, 2020
Copy link
Member

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeffwecan jeffwecan added bug auth methods generally related to a Vault auth method labels Dec 14, 2020
@jeffwecan jeffwecan merged commit 3b1dc9b into hvac:develop Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth methods generally related to a Vault auth method bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unimplemented auth method error message is not templated
2 participants