Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable response wrapping of PKI secrets #649

Merged
merged 1 commit into from Dec 14, 2020

Conversation

tmcolby
Copy link
Contributor

@tmcolby tmcolby commented Dec 1, 2020

Methods generate_intermediate and generate_root, if called with type='exported', expose the private key in the response. Additionally, generate_certificate also exposes the private key in the response.
This PR adds the wrap_ttl keyword argument to these methods that enables response wrapping of these calls.
https://www.vaultproject.io/docs/concepts/response-wrapping

@tmcolby tmcolby requested a review from a team as a code owner December 1, 2020 21:25
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #649 (74d55b7) into develop (7a8642e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #649   +/-   ##
========================================
  Coverage    84.01%   84.01%           
========================================
  Files           61       61           
  Lines         3203     3203           
========================================
  Hits          2691     2691           
  Misses         512      512           
Impacted Files Coverage Δ
hvac/api/secrets_engines/pki.py 100.00% <100.00%> (ø)

@tmcolby
Copy link
Contributor Author

tmcolby commented Dec 4, 2020

hi, what is the cadence for approving PR's and official releases? i want to use hvac in a large enterprise project, but i need the feature in this PR. i will need to be able to pull a release from pypi using requirements.txt to satisfy the devops folks - i dont think they will like pulling from my repo and building.
so with that said - can you tell me the likely hood of this getting approved and a realistic sense if it can make it into a release? im not asking for special attention - just trying to understand if i need to go another route. thanks for any feedback.

@jeffwecan jeffwecan added the enhancement a new feature or addition label Dec 14, 2020
@jeffwecan
Copy link
Member

@tmcolby: Sorry for the delay in getting to this PR and your query! We typically aim to create new releases more-or-less anytime PRs have been merged in. In reality, I haven't been able to make as much time for this project to hit that cadence (obviously :P). That said, I was planning on release a new version, with these changes included, over the next hour or so. 👍

@jeffwecan jeffwecan merged commit a7cbc59 into hvac:develop Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature or addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants