Fix oidc login and add working example #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #638 +/- ##
========================================
Coverage 83.49% 83.49%
========================================
Files 59 59
Lines 3103 3103
========================================
Hits 2591 2591
Misses 512 512
|
jeffwecan
added
documentation
jeffwecan
approved these changes
Sep 28, 2020
| @@ -1,5 +1,21 @@ | |||
| # Changelog | |||
|
|
|||
| ## 0.10.6 () | |||
There was a problem hiding this comment.
FYI, these changelog entries actually get drafted as PRs are merged and then updated during the release process (https://github.com/hvac/hvac/blob/develop/CONTRIBUTING.md#creating--publishing-releases). Including them in this PR is no trouble either tho.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed #631.
In addition to the fixed get request, I added an working example as well.
If anything should be change, just let me know :)