New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth_methods module to support AppRole #637
Conversation
I was looking for this... can we please review this one? :) |
@jeffwecan Can we assign this to someone for review please? |
For sure! I'll aim to get this reviewed over the next day or so. |
Some (relatively) unrelated integration test cases appear to be failing here. I'm still working on tracking down exactly what is occurring there... |
Sorry for the extended delay getting back to this PR! @discogestalt I pushed up a tweak to your approle additions here: bd353a8. Most all our auth I'm still tracking down some other issues but will aim to get them squared away today. |
Codecov Report
@@ Coverage Diff @@
## develop #637 +/- ##
===========================================
+ Coverage 83.49% 84.01% +0.51%
===========================================
Files 59 61 +2
Lines 3103 3203 +100
===========================================
+ Hits 2591 2691 +100
Misses 512 512
|
This PR deprecates the methods for AppRole authentication in the base client and adds an
AppRole
class toauth_methods
. It includes tests and full docstrings for the class.