Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth_methods module to support AppRole #637

Merged
merged 4 commits into from Oct 31, 2020

Conversation

discogestalt
Copy link
Contributor

This PR deprecates the methods for AppRole authentication in the base client and adds an AppRole class to auth_methods. It includes tests and full docstrings for the class.

@discogestalt discogestalt requested a review from a team as a code owner September 22, 2020 18:24
@krish7919
Copy link

I was looking for this... can we please review this one? :)

@krish7919
Copy link

@jeffwecan Can we assign this to someone for review please?

@jeffwecan
Copy link
Member

For sure! I'll aim to get this reviewed over the next day or so.

@jeffwecan
Copy link
Member

Some (relatively) unrelated integration test cases appear to be failing here. I'm still working on tracking down exactly what is occurring there...

@jeffwecan
Copy link
Member

Sorry for the extended delay getting back to this PR! @discogestalt I pushed up a tweak to your approle additions here: bd353a8. Most all our auth login() method default to setting the client's token attribute to the one sent back in an authentication response. In this case, the divergence made itself known through that unrelated JWT auth test case failure.

I'm still tracking down some other issues but will aim to get them squared away today.

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #637 into develop will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #637      +/-   ##
===========================================
+ Coverage    83.49%   84.01%   +0.51%     
===========================================
  Files           59       61       +2     
  Lines         3103     3203     +100     
===========================================
+ Hits          2591     2691     +100     
  Misses         512      512              
Impacted Files Coverage Δ
hvac/api/auth_methods/__init__.py 80.76% <100.00%> (+0.76%) ⬆️
hvac/api/auth_methods/approle.py 100.00% <100.00%> (ø)
hvac/constants/approle.py 100.00% <100.00%> (ø)
hvac/v1/__init__.py 86.58% <100.00%> (+0.27%) ⬆️

@jeffwecan jeffwecan merged commit 9e5fc70 into hvac:develop Oct 31, 2020
@jeffwecan jeffwecan added approle AppRole auth method enhancement a new feature or addition labels Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approle AppRole auth method enhancement a new feature or addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants