Remove Consul Secrets Engine create_or_update_role Policy Type Validation #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #636 +/- ##
===========================================
+ Coverage 83.41% 83.49% +0.08%
===========================================
Files 59 59
Lines 3106 3103 -3
===========================================
Hits 2591 2591
+ Misses 515 512 -3
|
jeffwecan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below change allows any version of consul newer than 1.4 to create tokens with the new policy system.
Current release of hvac means I can only create a token that maps to an existing policy if it's a management type token, which is not ideal as newer versions will warn that you are using 'legacy type tokens' and suggest going to documentation to upgrade your tokens.
A management token has global rights within the system, so this is expressly not wanted most of the time for generating tokens.