Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update health.py to match new Vault API query parameters #635

Merged
merged 2 commits into from Sep 21, 2020
Merged

Update health.py to match new Vault API query parameters #635

merged 2 commits into from Sep 21, 2020

Conversation

leongyh
Copy link
Contributor

@leongyh leongyh commented Sep 17, 2020 •
edited

Updated to match updated query parameters on Vault API.

https://www.vaultproject.io/api-docs/system/health

Seems like the parameters do not have _ anymore.

@leongyh
Update health.py
11fdc9d 
Updated to match updated query parameters on Vault API.

https://www.vaultproject.io/api-docs/system/health
@leongyh leongyh requested a review from a team as a code owner September 17, 2020 17:56
@leongyh leongyh changed the title Update health.py Update health.py to match new Vault API query parameters Sep 17, 2020
jeffwecan
jeffwecan approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out :)

Thanks for the contribution!

@jeffwecan jeffwecan added misc Used as a release-drafter "category" system backend generally related to the Vault system backend routes labels Sep 21, 2020
@jeffwecan jeffwecan merged commit 4b4532d into hvac:develop Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwecan jeffwecan jeffwecan approved these changes

Assignees
No one assigned
Labels
misc Used as a release-drafter "category" system backend generally related to the Vault system backend routes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leongyh @jeffwecan