Fix transit constants for "generate_data_key" #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Official documentation (https://www.vaultproject.io/api-docs/secret/transit#generate-data-key) and your own documentation (https://hvac.readthedocs.io/en/stable/usage/secrets_engines/transit.html#generate-data-key) only mentions "plaintext" and "wrapped" as valid value, while "ciphertext" was written here. Moreover, "ciphertext" is not valid and results in the following traceback : Traceback (most recent call last): File "[...]", line 91, in runcode exec(code, self.locals) File "<input>", line 4, in <module> File "[...]/hvac/api/secrets_engines/transit.py", line 504, in generate_data_key json=params, File "[...]/hvac/adapters.py", line 107, in post return self.request('post', url, **kwargs) File "[...]/hvac/adapters.py", line 342, in request response = super(JSONAdapter, self).request(*args, **kwargs) File "[...]/hvac/adapters.py", line 309, in request errors=errors File "[...]/hvac/utils.py", line 37, in raise_for_error raise exceptions.InvalidRequest(message, errors=errors, method=method, url=url) hvac.exceptions.InvalidRequest: Invalid path, must be 'plaintext' or 'wrapped', on post https://[...]
Angeall
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For transit "generate_data_key" function, the official documentation and your own documentation only mentions "plaintext" and "wrapped" as valid value for the key type.
The problem is that "ciphertext" seems to replace "wrapped" in your constant.
Moreover, "ciphertext" is not valid and results in the following traceback :