Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PUT method in secrets engine kv_v1 to use PUT instead of POST #629

Merged
merged 1 commit into from Sep 14, 2020
Merged

Fix PUT method in secrets engine kv_v1 to use PUT instead of POST #629

merged 1 commit into from Sep 14, 2020

Conversation

ghTravis
Copy link
Contributor

When specifying method='PUT' in the .create_or_update_secret function it will use POST no matter what. This should be changed to .put instead of .post

@ghTravis ghTravis requested a review from a team as a code owner September 11, 2020 16:32
jeffwecan
jeffwecan approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeffwecan jeffwecan merged commit 4697d5e into hvac:develop Sep 14, 2020
@jeffwecan jeffwecan added bug kv Key/Value (KV) secrets engine labels Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwecan jeffwecan jeffwecan approved these changes

Assignees
No one assigned
Labels
bug kv Key/Value (KV) secrets engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghTravis @jeffwecan