Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rabbitmq vhost_topics parameter #626

Merged
merged 1 commit into from Aug 25, 2020

Conversation

JJCella
Copy link
Contributor

@JJCella JJCella commented Aug 24, 2020

Fixes #625

@JJCella JJCella requested a review from a team as a code owner August 24, 2020 18:45
@JJCella JJCella changed the title Add rabbitmq vhost_topic parameter Add rabbitmq vhost_topics parameter Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #626 into develop will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #626   +/-   ##
========================================
  Coverage    83.41%   83.41%           
========================================
  Files           59       59           
  Lines         3106     3106           
========================================
  Hits          2591     2591           
  Misses         515      515           
Impacted Files Coverage Δ
hvac/api/secrets_engines/rabbitmq.py 42.30% <100.00%> (ø)

@jeffwecan jeffwecan added the enhancement a new feature or addition label Aug 25, 2020
@jeffwecan
Copy link
Member

Thanks!

@jeffwecan jeffwecan merged commit 183051f into hvac:develop Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature or addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rabbitmq role creation - vhost_topics parameter is missing
2 participants